Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copter: disable sport mode #20053

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Conversation

rmackay9
Copy link
Contributor

This disables Copter's sport mode by default. This mode allows the pilot to control the vertical speed (like AltHold mode) but lean angle using body-frame rates (like Acro). This mode seemed like a good idea at the time to Leonard and I but in practice nobody ever uses it (not even us).

In all my years supporting releases I have never seen a log with a user flying in Sport mode so I think we should actually remove it completely but before we do that, let's disable it and see how many people complain. For 4.2 at least it will be available using the custom build server.

As we search around for more flash space, let's consider simplifying the code base by removing unused features.

@rmackay9 rmackay9 merged commit 10f4500 into ArduPilot:master Feb 11, 2022
@rmackay9
Copy link
Contributor Author

Merged, thanks

@rmackay9 rmackay9 deleted the copter-sport-disabled branch February 11, 2022 07:12
@Johnex
Copy link

Johnex commented Jun 6, 2022

Can we revert this? I use it for doing dolly shots with my drone, and it's a huge pain to have to build a custom firmware for it every time. Also, in time all the GCS and Lua scripts will also drop support making it even harder to use.

If there was a way to tell AltHold to keep the vehicle attitude when sticks are centered, then i would say remove this, but since there is no alternative mode that does the same, then could we keep this? fingers crossed

@Johnex
Copy link

Johnex commented Jun 6, 2022

@rmackay9 In the mean time, what options do i have to select in the custom build server to have exactly the same features as the default firmware for Durandal-dshot, but including Sport mode?

@rmackay9
Copy link
Contributor Author

rmackay9 commented Jun 6, 2022

Hi @Johnex,

We disabled sport mode because we couldn't find any users of it. Now that you've appeared we will reconsider that choice..

Thanks for posting.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants